Repository navigation
Fix unbounded RetryConfig check accumulation - #1446
Conversation
Merging this PR will improve performance by 15.09%1 warning
Performance Changes
Tip Curious why performance improved? Comment Comparing Footnotes |
sirosen
left a comment
There was a problem hiding this comment.
Ach! This one is disappointing because it reveals that I messed up the design for this config. It really shouldn't be mutable. I want us to file an issue for v5 to fix that. We'll need to change a bunch of interfaces, I bet.
Fixed
Fix a bug that allowed duplicate
RetryConfigchecks to accumulate.This bug could be triggered by instantiating
RetryConfigonceand passing that instance to multiple SDK clients.
RetryCheckCollection.register_checknow ignores a checkwhich is already registered.