Skip to content

Fix unbounded RetryConfig check accumulation - #1446

Merged
kurtmckee merged 2 commits into
mainfrom
fix-retry-config-check-accumulation
Nov 7, 2026
Merged

kurtmckee merged 2 commits into
mainfrom
fix-retry-config-check-accumulation

Conversation

@kurtmckee

Copy link
Copy Markdown
Member

Fixed

  • Fix a bug that allowed duplicate RetryConfig checks to accumulate.

    This bug could be triggered by instantiating RetryConfig once
    and passing that instance to multiple SDK clients.

    RetryCheckCollection.register_check now ignores a check
    which is already registered.

@codspeed

codspeed Bot commented Nov 6, 2026

Copy link
Copy Markdown

Merging this PR will improve performance by 15.09%

1 warning

⚠️ 1 benchmark with a significant change ran on different hardware

Its base and head results were measured on machines with a different CPU, core count or memory, so the change might not come from the code. Run base and head on the same runner type.

Learn more about Macro Runners

See affected benchmarks

⚡ 1 improved benchmark
✅ 17 untouched benchmarks

Performance Changes

Benchmark BASE HEAD Efficiency
⚡ test_deeply_nested_object_encoding[5w-1d] 173 µs 150.3 µs +15.09%

Tip

Curious why performance improved? Comment @codspeedbot explain why performance improved on this PR, or directly use the CodSpeed MCP with your agent.


Comparing fix-retry-config-check-accumulation (892b5d6) with main (9f5191a)1

Open in CodSpeed

Footnotes

  1. No successful run was found on main (c7e83bb) during the generation of this report, so 9f5191a was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩

@sirosen sirosen left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ach! This one is disappointing because it reveals that I messed up the design for this config. It really shouldn't be mutable. I want us to file an issue for v5 to fix that. We'll need to change a bunch of interfaces, I bet.

@kurtmckee
kurtmckee merged commit bbe2899 into main Nov 7, 2026
12 checks passed
@kurtmckee
kurtmckee deleted the fix-retry-config-check-accumulation branch November 7, 2026 00:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants